Port to Mojmap #596
Merged
Port to Mojmap #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earthcomputer
requested changes
Feb 2, 2024
|
I did that though. Please let me know which ones I missed. |
|
Alright, I've made a second pass through the codebase. Hopefully I got them all. |
xpple
previously requested changes
Feb 4, 2024
|
Using wildcard imports for static imports matches CONTRIBUTING.md. |
|
Yes, but those need not be reverted as those weren't changed. I am referring to regular wildcard imports being removed in various places. |
|
I think that's fine tbh, this PR changes almost every file anyway |
|
Sure, but at least in |
Earthcomputer
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the entire mod to Mojmap, including renaming things that were named for Yarn things.